Skip to content

Replace metrics batch processor with sending queue #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafaelwestphal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace metrics batch processor with sending queue #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion confgenerator/confgenerator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,19 @@ func otlpExporterForMetrics(userAgent string) otel.Component {
"headers": map[string]string{
"User-Agent": userAgent,
},
"sending_queue": map[string]interface{}{
"enabled": true,
"queue_size": 12000,
"num_consumers": 10,
"sizer": "items",
"block_on_overflow": true,
"batch": map[string]interface{}{
"flush_timeout": "200ms",
Copy link
Copy Markdown
Contributor

@XuechunHou XuechunHou Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to increase the flush_timeout

https://screenshot.googleplex.com/LtnCgHzkACvqTHW Cloud Monitoring requires data points for a time series to be sent at least five seconds apart. We could set the flush timeout to 5 seconds.

"min_size": 200,
"max_size": 200,
"sizer": "items",
},
},
},
}
}
Expand Down Expand Up @@ -259,7 +272,6 @@ func (uc *UnifiedConfig) GenerateOtelConfig(ctx context.Context, outDir, stateDi
"metrics": {
otel.GCPProjectID(resource.ProjectName()),
otel.MetricStartTime(),
otel.BatchProcessor(200, 200, "200ms"),
},
},
},
Expand Down
23 changes: 11 additions & 12 deletions .../goldens/combined-receiver_otlp_otel_logging_otlpgrpc_exporter/golden/linux-gpu/otel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@ exporters:
endpoint: telemetry.googleapis.com:443
headers:
User-Agent: Google-Cloud-Ops-Agent-Metrics/latest (BuildDistro=build_distro;Platform=linux;ShortName=linux_platform;ShortVersion=linux_platform_version)
sending_queue:
batch:
flush_timeout: 200ms
max_size: 200
min_size: 200
sizer: items
block_on_overflow: true
enabled: true
num_consumers: 10
queue_size: 12000
sizer: items
extensions:
file_storage:
create_directory: true
Expand All @@ -42,10 +53,6 @@ processors:
agentmetrics/hostmetrics_0:
blank_label_metrics:
- system.cpu.utilization
batch/otlp_grpc/otlp_metrics_metrics_2:
send_batch_max_size: 200
send_batch_size: 200
timeout: 200ms
cumulativetodelta/loggingmetrics_4:
include:
match_type: strict
Expand Down Expand Up @@ -1249,7 +1256,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- hostmetrics/hostmetrics
metrics/default__pipeline_hostmetrics_1:
Expand All @@ -1263,7 +1269,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- nvml/hostmetrics_1
metrics/fluentbit:
Expand All @@ -1278,7 +1283,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/loggingmetrics:
Expand All @@ -1300,7 +1304,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/opsagent:
Expand All @@ -1313,7 +1316,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlpjsonfile/ops_agent
metrics/otel:
Expand All @@ -1330,7 +1332,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/otlp2_otlpgooglecloudmonitoring:
Expand All @@ -1341,7 +1342,6 @@ service:
- resourcedetection/_global_1
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlpgooglecloudmonitoring
metrics/otlp_otlp:
Expand All @@ -1355,7 +1355,6 @@ service:
- metricstransform/otlp_4
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlp
traces/traces_otlp_otlp:
Expand Down
22 changes: 11 additions & 11 deletions ...data/goldens/combined-receiver_otlp_otel_logging_otlpgrpc_exporter/golden/linux/otel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@ exporters:
endpoint: telemetry.googleapis.com:443
headers:
User-Agent: Google-Cloud-Ops-Agent-Metrics/latest (BuildDistro=build_distro;Platform=linux;ShortName=linux_platform;ShortVersion=linux_platform_version)
sending_queue:
batch:
flush_timeout: 200ms
max_size: 200
min_size: 200
sizer: items
block_on_overflow: true
enabled: true
num_consumers: 10
queue_size: 12000
sizer: items
extensions:
file_storage:
create_directory: true
Expand All @@ -42,10 +53,6 @@ processors:
agentmetrics/hostmetrics_0:
blank_label_metrics:
- system.cpu.utilization
batch/otlp_grpc/otlp_metrics_metrics_2:
send_batch_max_size: 200
send_batch_size: 200
timeout: 200ms
cumulativetodelta/loggingmetrics_4:
include:
match_type: strict
Expand Down Expand Up @@ -1203,7 +1210,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- hostmetrics/hostmetrics
metrics/fluentbit:
Expand All @@ -1218,7 +1224,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/loggingmetrics:
Expand All @@ -1240,7 +1245,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/opsagent:
Expand All @@ -1253,7 +1257,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlpjsonfile/ops_agent
metrics/otel:
Expand All @@ -1270,7 +1273,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/otlp2_otlpgooglecloudmonitoring:
Expand All @@ -1281,7 +1283,6 @@ service:
- resourcedetection/_global_1
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlpgooglecloudmonitoring
metrics/otlp_otlp:
Expand All @@ -1295,7 +1296,6 @@ service:
- metricstransform/otlp_4
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlp
traces/traces_otlp_otlp:
Expand Down
24 changes: 11 additions & 13 deletions ...ldens/combined-receiver_otlp_otel_logging_otlpgrpc_exporter/golden/windows-2012/otel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@ exporters:
endpoint: telemetry.googleapis.com:443
headers:
User-Agent: Google-Cloud-Ops-Agent-Metrics/latest (BuildDistro=build_distro;Platform=windows;ShortName=win_platform;ShortVersion=win_platform_version)
sending_queue:
batch:
flush_timeout: 200ms
max_size: 200
min_size: 200
sizer: items
block_on_overflow: true
enabled: true
num_consumers: 10
queue_size: 12000
sizer: items
extensions:
file_storage:
create_directory: true
Expand All @@ -42,10 +53,6 @@ processors:
agentmetrics/hostmetrics_0:
blank_label_metrics:
- system.cpu.utilization
batch/otlp_grpc/otlp_metrics_metrics_2:
send_batch_max_size: 200
send_batch_size: 200
timeout: 200ms
casttosum/iis_1:
metrics:
- agent.googleapis.com/iis/network/transferred_bytes_count
Expand Down Expand Up @@ -1716,7 +1723,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- hostmetrics/hostmetrics
metrics/default__pipeline_iis:
Expand All @@ -1733,7 +1739,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- windowsperfcounters/iis
metrics/default__pipeline_mssql:
Expand All @@ -1748,7 +1753,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- windowsperfcounters/mssql
metrics/fluentbit:
Expand All @@ -1763,7 +1767,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/loggingmetrics:
Expand All @@ -1785,7 +1788,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/opsagent:
Expand All @@ -1798,7 +1800,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlpjsonfile/ops_agent
metrics/otel:
Expand All @@ -1815,7 +1816,6 @@ service:
- resourcedetection/_global_0
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- prometheus/agent_prometheus
metrics/otlp2_otlpgooglecloudmonitoring:
Expand All @@ -1826,7 +1826,6 @@ service:
- resourcedetection/_global_1
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlpgooglecloudmonitoring
metrics/otlp_otlp:
Expand All @@ -1840,7 +1839,6 @@ service:
- metricstransform/otlp_4
- resource/otlp_grpc/otlp_metrics_metrics_0
- metricstarttime/otlp_grpc/otlp_metrics_metrics_1
- batch/otlp_grpc/otlp_metrics_metrics_2
receivers:
- otlp/otlp
traces/traces_otlp_otlp:
Expand Down
Loading
Loading