Centralized port config in environment#2276
Open
rafaelwestphal wants to merge 5 commits intomasterfrom
Open
Conversation
This commit implements the prototype for environment variable port configuration in the Ops Agent. It allows users to set independent metrics ports for Fluent Bit and OpenTelemetry Collector using environment variables: - OPS_AGENT_FLUENT_BIT_METRICS_PORT - OPS_AGENT_OTEL_METRICS_PORT - Added methods to UnifiedConfig to read ports from env vars. - Updated confgenerator and otel/modular to use these ports. - Added unit tests to verify behavior. TAG=agy CONV=062b1ae6-6d88-486e-a584-a82f970e5ae4
rafaelwestphal
changed the title
rafaelwestphal
changed the title
rafaelwestphal
changed the title
braydonk
reviewed
Apr 27, 2026
| } | ||
|
|
||
| func (uc *UnifiedConfig) GetFluentBitMetricsPort() uint16 { | ||
| if portStr := os.Getenv("OPS_AGENT_FLUENT_BIT_METRICS_PORT"); portStr != "" { |
Contributor
There was a problem hiding this comment.
I like Quentin's suggestion to make these env vars prefixed with EXPERIMENTAL (EXPERIMENT? whatever our convention is).
Might also be good to make the environment variable names a constant, that way the tests can use the constant too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose an environment variable that allows customer to set sub-agent ports.
Related issue
b/236599678
How has this been tested?
Integration test.
Checklist: