This repository was archived by the owner on Aug 20, 2025. It is now read-only.
adds a script to create rule templates with CRD based naming#193
Open
yunus wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Open
adds a script to create rule templates with CRD based naming#193yunus wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
yunus wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
yunus
requested review from
AdrienWalkowiak,
briantkennedy,
joecheuk,
morgante and
t12g
as code owners
Member
Author
|
Hey there, Is there anyone taking this? Any feedback? |
morgante
reviewed
Dec 5, 2019
Contributor
morgante
left a comment
morgante
left a comment
There was a problem hiding this comment.
Sorry for the delay.
One suggestion: instead of building and maintaining a custom script for generating these, could we simply leverage cookiecutter?
Member
Author
|
I will check it, looks like a better alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is cumbersome to deal with CRD, metadata naming and creating all the rego, template and sample files, I have created a script that creates
by using Jinja2.
The templates are filled with vm-external-ip example. When you run
make create_new_ruleit asks for resource, feature, version and human readable name.