This repository was archived by the owner on Aug 20, 2025. It is now read-only.
CIS 1.07 & 1.09: Separation of duties#240
Open
charliewolf wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
CIS 1.07 & 1.09: Separation of duties#240charliewolf wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
charliewolf wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
charliewolf
requested review from
AdrienWalkowiak,
briantkennedy,
joecheuk,
morgante and
t12g
as code owners
charliewolf
force-pushed
the
feature/cis/1.07
branch
from
254bf84 to
9d0b5e8
Compare
joecheuk
reviewed
Jan 8, 2020
| severity: high | ||
| parameters: | ||
| roles: | ||
| - - roles/cloudkms.admin |
Contributor
There was a problem hiding this comment.
why is the extra dash needed here?
e.g.
roles:
- - roles/cloudkms.admin
- roles/cloudkms.cryptoKeyDecrypter
instead of
roles:
- roles/cloudkms.admin
roles/cloudkms.cryptoKeyDecrypter
Contributor
Author
There was a problem hiding this comment.
@joecheuk because it's a list of lists of roles, not a list of roles. each list is a set that the exclusion is calculated for.
Contributor
|
@gkowalski-google can you please review and help Charlie get this merged. I think he has addressed Joe's questions/feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.