Skip to content

fix: custom query row validation on Db2 loses precision and scale#1709

Closed
anzzyspeaksgit wants to merge 7 commits intoGoogleCloudPlatform:developfrom
anzzyspeaksgit:fix/issue-1706
Closed

fix: custom query row validation on Db2 loses precision and scale#1709
anzzyspeaksgit wants to merge 7 commits intoGoogleCloudPlatform:developfrom
anzzyspeaksgit:fix/issue-1706

Conversation

@anzzyspeaksgit
Copy link
Copy Markdown

Summary

Fixes an issue where custom query row validation on Db2 loses decimal precision and scale because it was ignoring cursor.description values.

Problem

Closes #1706

Solution

Updated _get_type() to receive the entire column tuple from cursor.description rather than just the type string, and extracted precision and scale (at indexes 4 and 5 respectively) when returning an Ibis Decimal data type. This mimics how PostgreSQL and Oracle extract type sizes.

Testing

  • Code updated
  • Lint passed

This PR was created with AI assistance.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 22, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nj1973 nj1973 requested review from nj1973 March 30, 2026 11:18
@nj1973
Copy link
Copy Markdown
Collaborator

nj1973 commented Mar 30, 2026

/gcbrun

@nj1973
Copy link
Copy Markdown
Collaborator

nj1973 commented Mar 30, 2026

@anzzyspeaksgit, thanks for contributing. The changes look good, I added a test to confirm they work.

We just need you to complete the contributor agreement as described here: #1709 (comment)

@nj1973
Copy link
Copy Markdown
Collaborator

nj1973 commented Apr 8, 2026

Thanks for the suggested fix but without a CLA we cannot merge this PR.

@nj1973 nj1973 closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom query row validation on Db2 loses precision and scale

2 participants