Skip to content

test: expanded rules api/v1/alerts tests to avoid confusion#1630

Merged
bwplotka merged 1 commit intomainfrom
alerting-empty-res
Apr 17, 2025
Merged

test: expanded rules api/v1/alerts tests to avoid confusion#1630
bwplotka merged 1 commit intomainfrom
alerting-empty-res

Conversation

@bwplotka
Copy link
Copy Markdown
Collaborator

Relates to: #1551

@bwplotka
Copy link
Copy Markdown
Collaborator Author

Something unrelated is broken on main, likely vendor?

bwplotka added a commit that referenced this pull request Apr 11, 2025
Fixes #1630 (comment)

Signed-off-by: bwplotka <bwplotka@google.com>
@bwplotka
Copy link
Copy Markdown
Collaborator Author

Fix #1631

bwplotka added a commit that referenced this pull request Apr 11, 2025
Fixes #1630 (comment)

Signed-off-by: bwplotka <bwplotka@google.com>
bwplotka added a commit that referenced this pull request Apr 11, 2025
Fixes #1630 (comment)

Signed-off-by: bwplotka <bwplotka@google.com>
@bwplotka bwplotka force-pushed the alerting-empty-res branch 4 times, most recently from d449322 to d1050a9 Compare April 14, 2025 09:35
Relates to: #1551

Signed-off-by: bwplotka <bwplotka@google.com>
@bwplotka bwplotka force-pushed the alerting-empty-res branch from d1050a9 to 84b2dab Compare April 15, 2025 11:40
@bwplotka bwplotka requested a review from bernot-dev April 16, 2025 11:39
Copy link
Copy Markdown
Collaborator

@bernot-dev bernot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwplotka bwplotka merged commit a29d207 into main Apr 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants