Ensure spack pkgman has the environment_(un)load_commands methods
#1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the (wrong) decoration of setting `environment_unload_commands` as a property in the base class.
linsword13
force-pushed
the
spack-pkgman
branch
from
d025a61 to
5eb4724
Compare
douglasjacobsen
approved these changes
Oct 31, 2025
douglasjacobsen
merged commit be00d58
into
GoogleCloudPlatform:develop
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the (wrong) decoration of setting
environment_unload_commandsas a property in the base class.One general change is to use
abc.ABCMetato enforce abstract methods on the package-manager-base, such that derived pkgmans are now required to implement these methods.