Apply linting suggestions from ruff
#1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command used is `ruff check hpc/ramble/lib/ramble/ramble/ hpc/ramble/var/ramble/repos/builtin/ --ignore B905,F405,F403,E402 --extend-select B`. It mainly contains: * Use of exception chaining, for better stack trace * Clean up unused loop variables * Fix up confusing names in loop * Fix up function variable binding in loop (https://docs.astral.sh/ruff/rules/function-uses-loop-variable/) * Misc. issues such as better assertion and attribute usage
douglasjacobsen
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in ruff check configuration.
The command used is
ruff check --config pyproject.toml(or simplyruff check).It mainly contains: