Add iterative variable definition based on variant values #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linsword13
reviewed
Nov 8, 2025
var/ramble/repos/builtin/base_classes/application-base/base_class.py
Outdated
Show resolved
Hide resolved
douglasjacobsen
force-pushed
the
varible-variant-iterative
branch
from
7a7a7a1 to
0a37fd1
Compare
linsword13
reviewed
Nov 8, 2025
This commit updates the logic for defining undefined variables based on the values of variants to be iterative. This allows variables to recursively update the definition of variants, before allowing them to define additional variables. Tests are added to cover this (arguably complex) case as well.
douglasjacobsen
force-pushed
the
varible-variant-iterative
branch
from
0a37fd1 to
874c776
Compare
linsword13
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the logic for defining undefined variables based on the values of variants to be iterative.
This allows variables to recursively update the definition of variants, before allowing them to define additional variables.
Tests are added to cover this (arguably complex) case as well.