Feature/enable public ip checkbox#40
Merged
RanJiang233 merged 2 commits intoGoogleCloudPlatform:mainfrom Mar 20, 2026
Merged
Conversation
|
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Added a user-configurable option to control public IP access when using custom networks in Vertex AI scheduler. Previously, enableInternetAccess was hardcoded to TRUE when a custom network was selected. Changes: - Backend: Added enable_public_ip field to DescribeVertexJob and DescribeUpdateVertexJob models (defaults to true for backward compatibility) - Backend: Modified vertex.py to respect enable_public_ip setting instead of hardcoding enableInternetAccess to TRUE - Frontend: Added Checkbox component to network configuration section - Frontend: Checkbox appears when custom network is selected (primary or shared) - Frontend: State management for enablePublicIp (defaults to true/checked) - Frontend: Payload includes enable_public_ip in create/edit operations - Frontend: Edit mode loads and displays existing enable_public_ip setting The checkbox is labeled "Enable public IP (allows internet access)" and is checked by default to maintain current behavior. Users can uncheck it to disable public IP access when using custom networks.
jeffreylwang
force-pushed
the
feature/enable-public-ip-checkbox
branch
from
eb008e9 to
be9385b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option for external IP in jupyter scheduler plugin