fix(build): enable BuildKit in cloudbuild-omni.yaml for --mount support - #1484
Merged
Merged
Conversation
The omni cloudbuild config uses plain `docker build` (not `docker buildx build`) because it chains images through the local daemon. The upstream harnesses/claude/Dockerfile now uses `RUN --mount=type=secret`, which requires BuildKit. This causes Stage 3 (build-scion-claude) to fail with "the --mount option requires BuildKit." Add `DOCKER_BUILDKIT=1` env var to all 8 docker build steps to enable BuildKit with the legacy builder. The `required=false` on the secret mount means no `--secret` flag is needed at build time. Applied to all stages (not just Stage 3) for consistency and to prevent the same failure when other Dockerfiles adopt `--mount`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Cloud Build configuration in image-build/cloudbuild-omni.yaml by enabling Docker BuildKit (DOCKER_BUILDKIT=1) across all build stages (Stages 1 through 8). There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The omni cloudbuild config uses plain docker build (not docker buildx build) because it chains images through the local daemon. Upstream harnesses/claude/Dockerfile now uses RUN --mount=type=secret which requires BuildKit. All other cloudbuild configs use buildx (which has BuildKit built-in). Fix: add DOCKER_BUILDKIT=1 env var to all 8 build steps. Fixes ptone#1453.