Skip to content

Enable Workload Identity Federation to work with provider - #454

Closed
joekiller wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
joekiller:main
Closed

Enable Workload Identity Federation to work with provider#454
joekiller wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
joekiller:main

Conversation

@joekiller

@joekiller joekiller commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

Presently the provider is limited to only work with GKE or Fleet Workload Identity pool providers. This PR ensures that the gcp provider may retrieve secrets on a cluster utilizing GOOGLE_APPLICATION_CREDENTIALS pointing to an audience pool provider backed by Workload Identity Federation with Kubernetes.

Included as well is a debug workflow which was instrumental in determining the most precise way to fix the absence of function and documentation updates to fill out points to help others utilize the secret driver backed by workload identity federation with kubernetes.

Fixes: #206

@google-cla

google-cla Bot commented Sep 10, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dargudear-google

Copy link
Copy Markdown
Member

Thanks for the PR. Will take a look at this.

@joekiller

Copy link
Copy Markdown
Contributor Author

I don't believe the e2e failure was directly due to the PR. seemed transient from the logs.

@dargudear-google

Copy link
Copy Markdown
Member

Can you split the PR into 2?
each one will server one purpose.

@joekiller

Copy link
Copy Markdown
Contributor Author

@dargudear-google by split, you mean one for the workload identity federation fix and one for the debug stuff?

@dargudear-google

Copy link
Copy Markdown
Member

@dargudear-google by split, you mean one for the workload identity federation fix and one for the debug stuff?

Yes

@joekiller

Copy link
Copy Markdown
Contributor Author

@dargudear-google I am closing this for #459 and #460.

@joekiller joekiller closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom workload identity pools

2 participants