fix: enable ADC for connect gateway and bump dev-tools to 1.28 - #759
fix: enable ADC for connect gateway and bump dev-tools to 1.28#759apeabody wants to merge 1 commit into
Conversation
apeabody
commented
Sep 4, 2026
apeabody
commented
- Configure Connect Gateway to use native Application Default Credentials (ADC) in testutils.ConnectToFleet and Cloud Build options.env. This prevents gke-gcloud-auth-plugin from invoking 'gcloud config config-helper', which crashes on Google Cloud SDK >= 573.0.0 due to upstream bug b/525047270.
- Bump cft/developer-tools to 1.28 across build configurations and Makefile.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the developer tools Docker image version from 1.25 to 1.28 across multiple build configuration files and the Makefile. It also configures the environment variable CLOUDSDK_CONTAINER_USE_APPLICATION_DEFAULT_CREDENTIALS to true in the build configurations and within the integration test utilities. The reviewer pointed out that setting this environment variable inside ConnectToFleet is redundant because it is already set globally in the package's init() function.
| t.Fatalf("Could not release creds lock: %v", err) | ||
| } | ||
| }() | ||
| os.Setenv("CLOUDSDK_CONTAINER_USE_APPLICATION_DEFAULT_CREDENTIALS", "true") |
There was a problem hiding this comment.
The environment variable CLOUDSDK_CONTAINER_USE_APPLICATION_DEFAULT_CREDENTIALS is already set to "true" globally in the package's init() function (lines 36-38). Setting it again here in ConnectToFleet is redundant and can be safely removed.
0ee7433 to
7462b76
Compare
- Configure Connect Gateway to use native Application Default Credentials (ADC) in testutils.ConnectToFleet and Cloud Build options.env. This prevents gke-gcloud-auth-plugin from invoking 'gcloud config config-helper', which crashes on Google Cloud SDK >= 573.0.0 due to upstream bug b/525047270. - Bump cft/developer-tools to 1.28 across build configurations and Makefile.
7462b76 to
922bc08
Compare
2 participants
