Skip to content

refactor: Use raw string in regex #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gericdong merged 5 commits into from
Apr 28, 2025
Merged

refactor: Use raw string in regex #4016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e2fd93
refactor: Use raw string in regex
gericdong Apr 28, 2025
f99c388
np.NaN was removed in the NumPy 2.0
gericdong Apr 28, 2025
d94b373
Move default python version to 3.10
gericdong Apr 28, 2025
751cdb2
Move back default python version to 3.9
gericdong Apr 28, 2025
2003030
Remove version mistmatched tes notebooks
gericdong Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cloud-build/execute_changed_notebooks_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def _get_notebook_python_version(notebook_path: str) -> str:

# Look for the python version specification pattern
re_match = re.search(
"python version = (\d+\.\d+)", markdown, flags=re.IGNORECASE
r"python version = (\d+\.\d+)", markdown, flags=re.IGNORECASE
)
if re_match:
# get the version number
Expand Down
2 changes: 0 additions & 2 deletions .cloud-build/test_notebook_vm.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
notebooks/official/vizier/gapic-vizier-multi-objective-optimization.ipynb
notebooks/official/pipelines/lightweight_functions_component_io_kfp.ipynb
notebooks/official/ml_metadata/sdk-metric-parameter-tracking-for-locally-trained-models.ipynb
notebooks/official/custom/custom-tabular-bq-managed-dataset.ipynb
.cloud-build/tests/python_version_test.ipynb
2 changes: 1 addition & 1 deletion notebooks/official/custom/custom-tabular-bq-managed-dataset.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@
"df = bq_client.list_rows(table).to_dataframe()\n",
"\n",
"# Drop unusable rows\n",
"df = df.replace(to_replace=NA_VALUES, value=np.NaN).dropna()\n",
"df = df.replace(to_replace=NA_VALUES, value=np.nan).dropna()\n",
"\n",
"# Convert categorical columns to numeric\n",
"df[\"island\"], _ = pd.factorize(df[\"island\"])\n",
Expand Down