Migrate gsutil usage to gcloud storage #4298
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates several Jupyter notebooks to utilize the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration of gsutil commands to gcloud storage across several notebooks. The migration is largely successful, but I've identified a critical issue in one of the command translations that will cause a runtime error. Additionally, there are some minor inconsistencies in the generated code. I've provided specific comments and code suggestions to address these points.
| " assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n", | ||
| " shell_output = ! gsutil ls -Lb {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n", | ||
| " bucket_region = shell_output[0].strip().lower()\n", | ||
| " shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n", " bucket_region = shell_output[0].strip().lower()\n", |
There was a problem hiding this comment.
The grep command is looking for "Location constraint:", but the output of gcloud storage ls --full --buckets uses "Location:". This will cause the command to fail and raise an IndexError on the next line. A more robust way to get the bucket location is to use gcloud storage buckets describe.
shell_output = !gcloud storage buckets describe {BUCKET_NAME} --format="value(location)"\n
There was a problem hiding this comment.
[Resolved] addressed with changing to Constraint
| "source": [ | ||
| "!gsutil cp gs://visionai-artifacts/visionai-0.0.6-py3-none-any.whl .\n", | ||
| "!pip install visionai-0.0.6-py3-none-any.whl --force-reinstall" | ||
| "!gcloud storage cp gs://visionai-artifacts/visionai-0.0.6-py3-none-any.whl .\n", "!pip install visionai-0.0.6-py3-none-any.whl --force-reinstall" |
There was a problem hiding this comment.
For consistency with other shell commands in this repository's notebooks, please add a space after the ! character.
! gcloud storage cp gs://visionai-artifacts/visionai-0.0.6-py3-none-any.whl .\n
There was a problem hiding this comment.
can be fixed only with linter
| "!gcloud storage rm --recursive $MODEL_URI\n", "!gcloud storage cp --recursive $model_path $MODEL_URI\n", "!gcloud storage ls --all-versions --long $MODEL_URI" ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
For consistency with other shell commands in this repository's notebooks, please add a space after the ! character on each of these lines.
"! gcloud storage rm --recursive $MODEL_URI\n",
"! gcloud storage cp --recursive $model_path $MODEL_URI\n",
"! gcloud storage ls --all-versions --long $MODEL_URI"
There was a problem hiding this comment.
can be fixed only with linter
This reverts commit c7a00a9.
| " serving_container_health_route=\"/ping\",\n", | ||
| " serving_container_environment_variables=serving_env,\n", | ||
| " model_garden_source_model_name=\"publishers/google/models/stable-diffusion-v1-4\"\n", | ||
| " model_garden_source_model_name=\"publishers/google/models/stable-diffusion-v1-4\",\n", |
There was a problem hiding this comment.
@gurusai-voleti, This change shouldn't happen, can you revert this?
There was a problem hiding this comment.
while running linter this is expected
googlyrahman
force-pushed
the
ai-gsutil-migration-1a72d88702124fbbb218e7db845aa6dc
branch
from
5abc2aa to
7cbdc7e
Compare
linter changes for 4298
…d88702124fbbb218e7db845aa6dc
removed changes in model_garden folder
3 participants
Automated: Migrate paths from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
cc: @sushantkhanna