Migrate gsutil usage to gcloud storage #4308
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates various Jupyter notebooks to replace Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration of gsutil commands to gcloud storage across several Jupyter notebooks. The automated changes are largely correct and align with the migration guide. I have identified two areas for improvement. First, I've corrected a shell command that was inefficient and potentially buggy, replacing it with a more idiomatic and robust version. Second, I've adjusted a gcloud command to ensure consistency in flag usage across the project. With these changes, the migration will be more robust and maintainable.
| "# create placeholder file for instructions for data labeling\n", | ||
| "! echo \"this is instruction\" >> instruction.txt | gsutil cp instruction.txt $BUCKET_URI" | ||
| ] | ||
| "! echo \"this is instruction\" >> instruction.txt | gcloud storage cp instruction.txt $BUCKET_URI" ] |
There was a problem hiding this comment.
This command is inefficient and the use of the pipe | is likely incorrect. It creates a local file instruction.txt and then attempts to upload it, but the pipe | sends the (empty) stdout of the echo >> command to gcloud storage cp, which is not the intended behavior. A more idiomatic and efficient approach is to pipe the output of echo directly to gcloud storage cp using - for stdin. This avoids creating an unnecessary local file.
! echo "this is instruction" | gcloud storage cp - "$BUCKET_URI/instruction.txt"
There was a problem hiding this comment.
[Resolved] fix not needed
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_NAME" | ||
| ] | ||
| "! gcloud storage buckets create --location $REGION $BUCKET_NAME" ] |
There was a problem hiding this comment.
For consistency with other gcloud commands in this pull request and for better readability, it's recommended to use an equals sign for assigning values to flags. While gcloud often accepts a space, using = is more explicit and less prone to parsing errors.
! gcloud storage buckets create --location=$REGION $BUCKET_NAME
There was a problem hiding this comment.
[Resolved] fixed inline with others
changes for 4308
removed model_garden folder changes
removed model_garden folder changes
3 participants
Automated: Migrate paths from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
cc: @sushantkhanna