Migrate gsutil usage to gcloud storage #4314
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates various Jupyter notebooks to use the modern Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration of gsutil commands to their gcloud storage equivalents across several Jupyter notebooks. The automated migration is largely successful, with most commands being correctly translated. However, I've identified a critical issue in one of the notebooks where parsing the output of a gcloud command will fail due to a case-sensitivity mismatch. Additionally, there are some minor inconsistencies in command-line flag formatting that should be addressed for better code quality and maintainability. After fixing these issues, the changes should be good to merge.
| " shell_output = ! gsutil ls -Lb {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n", | ||
| " bucket_region = shell_output[0].strip().lower()\n", | ||
| # Note: The format of the full listing output is different. gcloud storage uses a title case for keys and will not display a field if its value is "None". | ||
| " shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n", " bucket_region = shell_output[0].strip().lower()\n", |
There was a problem hiding this comment.
This command will fail because it's parsing the output of gcloud storage ls incorrectly. The note on the previous line correctly points out that gcloud storage uses title case for keys, so grep should be looking for Location Constraint: instead of Location constraint:. The sed command also needs to be updated to match the title case string.
shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep "Location Constraint:" | sed "s/Location Constraint: *//"
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_URI" ] |
There was a problem hiding this comment.
For consistency with other commands in this pull request and general gcloud command-line style, it's better to use a space to separate the --location flag and its value, rather than an equals sign.
"! gcloud storage buckets create --location $REGION $BUCKET_URI"
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_NAME" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_NAME" ] |
There was a problem hiding this comment.
For consistency with other commands in this pull request and general gcloud command-line style, it's better to use a space to separate the --location flag and its value, rather than an equals sign.
"! gcloud storage buckets create --location $REGION $BUCKET_NAME"
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_NAME" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_NAME" ] |
There was a problem hiding this comment.
For consistency with other commands in this pull request and general gcloud command-line style, it's better to use a space to separate the --location flag and its value, rather than an equals sign.
"! gcloud storage buckets create --location $REGION $BUCKET_NAME"
| "source": [ | ||
| "! gsutil mb -l {LOCATION} {BUCKET_URI}" | ||
| ] | ||
| "! gcloud storage buckets create --location={LOCATION} {BUCKET_URI}" ] |
There was a problem hiding this comment.
For consistency with other commands in this pull request and general gcloud command-line style, it's better to use a space to separate the --location flag and its value, rather than an equals sign.
"! gcloud storage buckets create --location={LOCATION} {BUCKET_URI}"
changes for 4314
removed model_garden changes
3 participants
Automated: Migrate paths from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
[email protected]We appreciate your partnership in this important migration effort!
cc: @sushantkhanna