Migrate gsutil usage to gcloud storage #4320
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the interaction with Google Cloud Storage within several Jupyter notebooks by migrating from the legacy Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated migration from gsutil to gcloud storage commands across several notebooks. The migration is mostly correct, but I've found a few issues that need manual intervention. These include missing equals signs in gcloud commands and incorrect comment formatting in notebook cells, which could lead to syntax errors. Please review the specific comments for details.
| ] | ||
| "! # Note: Migrating scripts using gsutil iam ch is more complex than get or set. You need to replace the single iam ch command with a series of gcloud storage bucket add-iam-policy-binding and/or gcloud storage bucket remove-iam-policy-binding commands, or replicate the read-modify-write loop.\n", | ||
| "! gcloud storage buckets add-iam-policy-binding $BUCKET_URI --member=serviceAccount:{SERVICE_ACCOUNT} --role=roles/storage.objectCreator\n", "\n", | ||
| # Note: Migrating scripts using gsutil iam ch is more complex than get or set. You need to replace the single iam ch command with a series of gcloud storage bucket add-iam-policy-binding and/or gcloud storage bucket remove-iam-policy-binding commands, or replicate the read-modify-write loop. |
There was a problem hiding this comment.
This line is a Python-style comment (# Note...) in a cell where shell commands are being executed (prefixed with !). This will cause a SyntaxError when the notebook cell is run. The comment should be a shell comment, prefixed with ! #. Additionally, it appears to be breaking the JSON format of the notebook file, as it's not a string literal within the source array.
| "source": [ | ||
| "! gsutil mb -l $LOCATION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location $LOCATION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command is missing an equals sign for the --location flag. It should be --location=$LOCATION.
"! gcloud storage buckets create --location=$LOCATION $BUCKET_URI"
There was a problem hiding this comment.
"! gcloud storage buckets create --location $LOCATION $BUCKET_URI" command is correct.
eg.gcloud storage buckets create --location $LOCATION $BUCKET_URI
Creating gs://vijay-bucket-090909/...
| "source": [ | ||
| "! gsutil mb -l $LOCATION -p $PROJECT_ID $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location $LOCATION --project $PROJECT_ID $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command is missing equals signs for the --location and --project flags. It should be --location=$LOCATION and --project=$PROJECT_ID.
"! gcloud storage buckets create --location=$LOCATION --project=$PROJECT_ID $BUCKET_URI"
There was a problem hiding this comment.
"! gcloud storage buckets create --location $LOCATION --project $PROJECT_ID $BUCKET_URI" command is correct
| "# Note: Migrating scripts using gsutil iam ch is more complex than get or set. You need to replace the single iam ch command with a series of gcloud storage bucket add-iam-policy-binding and/or gcloud storage bucket remove-iam-policy-binding commands, or replicate the read-modify-write loop.\n", | ||
| "! gcloud storage buckets add-iam-policy-binding $BUCKET_URI --member=serviceAccount:{SERVICE_ACCOUNT} --role=roles/storage.objectCreator\n", "# Note: Migrating scripts using gsutil iam ch is more complex than get or set. You need to replace the single iam ch command with a series of gcloud storage bucket add-iam-policy-binding and/or gcloud storage bucket remove-iam-policy-binding commands, or replicate the read-modify-write loop.\n", | ||
| "! gcloud storage buckets add-iam-policy-binding $BUCKET_URI --member=serviceAccount:{SERVICE_ACCOUNT} --role=roles/storage.objectViewer\n", | ||
| # TODO: Command "gsutil iam ch" could not be translated because it is missing the required bucket URL. Manual review required. | ||
| "! gsutil iam ch serviceAccount:{SERVICE_ACCOUNT}:roles/dataflow.developer" ] |
There was a problem hiding this comment.
This cell contains Python-style comments (# Note..., # TODO...) in a context where shell commands are being executed (prefixed with !). This will cause a SyntaxError when the notebook cell is run. All comments in this cell should be shell comments, prefixed with ! #. Additionally, some comments are not properly quoted as strings in the notebook's JSON structure, which will cause it to fail to load.
…849207017489a85a6d8c430370603 Changes for 4320
…849207017489a85a6d8c430370603 removed changes for model garden PR GoogleCloudPlatform#4320
4 participants
Automated: Migrate paths from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
[email protected]We appreciate your partnership in this important migration effort!
cc: @sushantkhanna