-
Notifications
You must be signed in to change notification settings - Fork 228
Add ADK inline source deployment tutorial for Agent Engine #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @jeremylongshore, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new tutorial notebook that guides users through the process of deploying Google Agent Development Kit (ADK) agents to Vertex AI Agent Engine using an inline source deployment method. This approach is crucial for complex agents, as it bypasses common serialization issues encountered with traditional pickle-based deployments, offering greater control over the deployment environment and ensuring compatibility. The tutorial covers the full lifecycle from agent creation and local testing to deployment and cleanup, making it a valuable resource for developers working with ADK and Agent Engine. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a well-structured and informative tutorial notebook on deploying ADK agents using inline source deployment. The notebook is clear and follows a logical flow. I've identified a critical issue with an incorrect model name that will cause the notebook to fail, and I've also provided a few suggestions to improve code robustness and maintainability. Overall, this is a valuable contribution once these minor issues are addressed.
notebooks/community/agent_engine/adk_inline_source_deployment.ipynb
Outdated
Show resolved
Hide resolved
notebooks/community/agent_engine/adk_inline_source_deployment.ipynb
Outdated
Show resolved
Hide resolved
notebooks/community/agent_engine/adk_inline_source_deployment.ipynb
Outdated
Show resolved
Hide resolved
|
I have signed the Google CLA. Please re-check. @googlebot I signed it! |
- Change model from gemini-2.0-flash to gemini-1.5-flash-001 - Improve exception handling with ZoneInfoNotFoundError
ef914a1 to
ad1f592
Compare
|
Commits have been rebased with the correct GitHub email (jeremylongshore@users.noreply.github.com). CLA should pass now. @googlebot I signed it! |
- Use specific ZoneInfoNotFoundError exception instead of generic Exception - Define REQUIREMENTS variable once and reuse to avoid duplication - Keep generic Exception as fallback for unexpected errors 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
@jeremylongshore please fix the failing checks. |
|
Fixed! The issue was a All commits now use @googlebot I signed it! |
|
@googlebot I signed it! |
1 similar comment
|
@googlebot I signed it! |
|
@googlebot I signed it! |
|
Thank you for your patience, @gericdong. The CLA check is now passing. I see the notebook format/lint check is failing - I'll run the linter and push the fixes. Appreciate your guidance. |
|
Hi @gericdong, I wanted to clarify the lint check failure. What I found:
Question: Thank you for your time. |
|
The linter test has been fixed. Thanks. |
Summary
This PR adds a tutorial notebook demonstrating how to deploy ADK agents to Vertex AI Agent Engine using inline source deployment.
Why this matters
Inline source deployment solves common issues with the default pickle-based deployment:
What's included
AgentEngineApp.from_agent()Background
I built this pattern while developing a multi-agent system with ADK. The project is featured in Google's Agent Starter Pack community showcase (PR #580, merged).
Checklist