-
Notifications
You must be signed in to change notification settings - Fork 228
feat: MongoDB voyage-4 launch #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Sam-Deciga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new official notebook into the repository, designed to guide users through the process of leveraging the Voyage 4 family of embedding models on Vertex AI. The notebook emphasizes the models' innovative capabilities, including a unified embedding space for flexible model mixing, and techniques for optimizing embedding size and precision to suit diverse application requirements. It serves as a comprehensive resource for deploying, utilizing, and understanding the advanced features of these powerful embedding models. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new notebook for the Voyage 4 embedding models. The notebook is well-structured and provides a good overview of the model's features.
My review includes a few suggestions to improve code maintainability and consistency:
- Updating an image URL to match the style of other notebooks.
- Refactoring two code cells to remove hardcoded values and magic numbers, making the code more robust and easier to read.
gericdong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the copyright year for 2026.
|
Copyright year updated to 2026 and changes applied by the partner |
REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.
--- YOUR PR SUMMARY GOES HERE --- MongoDB voyage-4 model launch on Jan 15, 2026 b/475223740
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooksunder the notebooks/official folder, follow this mandatory checklist:Official Notebookssection, pointing to the author or the author's team.Community Notebooksunder the notebooks/community folder:Community Notebookssection, pointing to the author or the author's team.Community Contentunder the community-content folder:Content Directory Nameis descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other contentCommunity Contentsection, pointing to the author or the author's team.