-
Notifications
You must be signed in to change notification settings - Fork 228
fix: Fix json response parsing error #4425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hyper-param, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a JSON response parsing error by updating a core dependency and streamlining the configuration of the HTTP DNA client within the quickstart notebook. These changes ensure the notebook leverages the most current Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the alphagenome wheel file version and removes the model_version parameter from the create_http_client call, which is stated to fix a JSON response parsing error. The changes are minimal and appear to address the stated issue.
| "print(\"Creating HttpDnaClient...\")\n", | ||
| "dna_model = dna_client_http.create_http_client(\n", | ||
| " vertex_ai_url=vertex_ai_url,\n", | ||
| " model_version=\"FOLD_0\",\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of model_version="FOLD_0" seems to address the 'json response parsing error' mentioned in the PR title. Could you add a brief comment explaining why this parameter was removed? For example, if FOLD_0 is no longer a valid version, or if the parameter itself is deprecated/no longer expected by the API. This would improve code clarity for future maintainers.
REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.
--- YOUR PR SUMMARY GOES HERE ---
REQUIRED: Fill out the below checklists or remove if irrelevan
Community Notebooksunder the notebooks/community folder:Community Notebookssection, pointing to the author or the author's team.