-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bumping node archives to latest stable versions #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Distroless Bot <[email protected]>
Summary of ChangesHello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Node.js runtime to its latest stable version, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Node.js archives to version 24.12.0. The changes are consistent across the Bazel lock file, build definitions, and test data. I've added one suggestion to refactor the node archive definitions in private/extensions/node.bzl to improve maintainability by reducing code duplication. This will make future version bumps easier.
| node_archive( | ||
| name = "nodejs24_amd64", | ||
| sha256 = "58a5ff5cc8f2200e458bea22e329d5c1994aa1b111d499ca46ec2411d58239ca", | ||
| strip_prefix = "node-v24.11.1-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-x64.tar.gz"], | ||
| version = "24.11.1", | ||
| sha256 = "6159227e0af7d7c3c6bb2fa900452b04a6cb8841a702a79acc613209d70b04d0", | ||
| strip_prefix = "node-v24.12.0-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.12.0/node-v24.12.0-linux-x64.tar.gz"], | ||
| version = "24.12.0", | ||
| architecture = "amd64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_arm64", | ||
| sha256 = "0dc93ec5c798b0d347f068db6d205d03dea9a71765e6a53922b682b91265d71f", | ||
| strip_prefix = "node-v24.11.1-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-arm64.tar.gz"], | ||
| version = "24.11.1", | ||
| sha256 = "9b2a2eeb98a8eb37361224e2a1d060300ad2dd143af58dfdb16de785df0f1228", | ||
| strip_prefix = "node-v24.12.0-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.12.0/node-v24.12.0-linux-arm64.tar.gz"], | ||
| version = "24.12.0", | ||
| architecture = "arm64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_ppc64le", | ||
| sha256 = "cd41407f3352de2f066ea26c5c5d0ea9b6362374d6b618385a9f2e9dad220616", | ||
| strip_prefix = "node-v24.11.1-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-ppc64le.tar.gz"], | ||
| version = "24.11.1", | ||
| sha256 = "66ec79b4d64f4109aedf822108715d0b6097118df9159c2f6321477da4ea17aa", | ||
| strip_prefix = "node-v24.12.0-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.12.0/node-v24.12.0-linux-ppc64le.tar.gz"], | ||
| version = "24.12.0", | ||
| architecture = "ppc64le", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_s390x", | ||
| sha256 = "5d4c8bca5f8f2593f9081dee39834760e85a16fa61c950f3e86ec85996f00550", | ||
| strip_prefix = "node-v24.11.1-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-s390x.tar.gz"], | ||
| version = "24.11.1", | ||
| sha256 = "8dc960a2555db1aa77fd131c25be571b9f7844bc8b278e78732b9f580fe7d580", | ||
| strip_prefix = "node-v24.12.0-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.12.0/node-v24.12.0-linux-s390x.tar.gz"], | ||
| version = "24.12.0", | ||
| architecture = "s390x", | ||
| control = "//nodejs:control", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and reduce code duplication, consider refactoring these repeated node_archive calls. You can define the version and architecture-specific details in a dictionary and loop through it to generate the archives. This will make future updates easier. Since this file appears to be generated by a script, you might need to update the script itself to incorporate this logic.
_NODE24_VERSION = "24.12.0"
_NODE24_ARCHS = {
"amd64": ("x64", "6159227e0af7d7c3c6bb2fa900452b04a6cb8841a702a79acc613209d70b04d0"),
"arm64": ("arm64", "9b2a2eeb98a8eb37361224e2a1d060300ad2dd143af58dfdb16de785df0f1228"),
"ppc64le": ("ppc64le", "66ec79b4d64f4109aedf822108715d0b6097118df9159c2f6321477da4ea17aa"),
"s390x": ("s390x", "8dc960a2555db1aa77fd131c25be571b9f7844bc8b278e78732b9f580fe7d580"),
}
for arch, (suffix, sha) in _NODE24_ARCHS.items():
node_archive(
name = "nodejs24_" + arch,
sha256 = sha,
strip_prefix = "node-v{version}-linux-{suffix}/".format(
version = _NODE24_VERSION,
suffix = suffix,
),
urls = ["https://nodejs.org/dist/v{version}/node-v{version}-linux-{suffix}.tar.gz".format(
version = _NODE24_VERSION,
suffix = suffix,
)],
version = _NODE24_VERSION,
architecture = arch,
control = "//nodejs:control",
)
|
🌳 🔄 Image Check This pull request has modified the following images: //nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_root_arm64_debian13
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian13
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_s390x_debian13
//nodejs:nodejs24_debug_root_amd64_debian13
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_nonroot_amd64_debian13
//nodejs:nodejs24_debug_nonroot_ppc64le_debian13
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_root_amd64_debian13
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian13
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian13
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian13
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian13
//nodejs:nodejs24_root_s390x_debian13
//nodejs:nodejs24_nonroot_ppc64le_debian13
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_nonroot_arm64_debian13
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian13
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian13You can check the details in the report here |
Signed-off-by: Distroless Bot [email protected]