-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: support parsing manifest config JSON containing data: (#4340)
#4346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: support parsing manifest config JSON containing data: (#4340)
#4346
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@chanseokoh I allowed myself to create this PR, is it ok with you ? |
|
I am not the repo maintainer, sorry. |
|
@mpeddada1 are you or do you know a maintainer for this project ? |
|
@ldetmer can you review this ? I am having difficulties using the latest debian images as source images. |
|
Hello @ldetmer, @mpeddada1 , @suztomo, @blakeli0 |
|
I facing the exactly same issue that should be corrected by this PR, anyone for review this one please ? |
|
I don't understand why this fix is not merged. I drop a way to patch your Base Image before using JIB. |
Fixes #4340 🛠️