Update gradle to 8.14.4#4475
Conversation
is the default starting in gradle 7+ https://docs.gradle.org/6.9.2/userguide/variant_attributes.html#sub:jvm_default_attributes https://docs.gradle.org/7.0/userguide/variant_attributes.html#sub:jvm_default_attributes https://docs.gradle.org/8.14.3/userguide/variant_attributes.html#sec:jvm-default-attributes
unit test failure due to incompatible API versions Previous spring boot version, 2.2.11.RELEASE used gradle API version 4.10.3 (https://github.com/spring-projects/spring-boot/blob/v2.2.11.RELEASE/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/gradle/wrapper/gradle-wrapper.properties) Current spring boot vesrion, 2.7.18 (latest allowed with java 8) uses gradle API version 7.6.3 (https://github.com/spring-projects/spring-boot/blob/v2.7.18/gradle/wrapper/gradle-wrapper.properties)
functionality was addressed by spring boot in 2.5.0, and support for this version ended 2023-08. The check within jib could be removed as well, but it does not get triggered since spring boot handles this already, so it is safe to leave in. https://spring.io/projects/spring-boot#support https://github.com/GoogleContainerTools/jib/blob/v3.5.2-gradle/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/JibPlugin.java#L166-L183
Gradle-generated 'propName value' or 'propName(value)' syntax in Groovy DSL has been deprecated
JavaPluginConvention type has been deprecated https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#java_convention_deprecation
ReportingExtension.getBaseDir() method has been deprecated https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#reporting-base-dir
Calling setCanBeResolved(true) on configuration has been deprecated and was not needed https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#configurations_allowed_usage
org.gradle.util.ConfigureUtil type has been deprecated https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#org_gradle_util_reports_deprecations
Cannot set the property 'requireBranch' because the backing field is final. https://github.com/researchgate/gradle-release?tab=readme-ov-file#configuration
The 'zstdSupport' feature was created using the main source set. This behavior has been deprecated. https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#deprecate_register_feature_main_source_set
The ProjectDependency.getDependencyProject() method has been deprecated https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#deprecate_get_dependency_project
Unresolvable link in javadoc tag with value FilesMojoV2#collectWatchParameters found in jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/SkaffoldConfiguration.java
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @mluckam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the project's build system by upgrading Gradle to its latest stable version, 8.14.4. This foundational update ensures compatibility with newer development environments and leverages recent Gradle features, while also addressing necessary adjustments in plugin configurations and build scripts. The changes streamline the build process, enhance maintainability, and prepare the project for future advancements in the Java and Gradle ecosystems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Gradle from version 6.9.2 to 8.14.4, along with several Gradle plugins to versions compatible with Gradle 8. The changes include updating the Gradle wrapper, modifying build scripts to use modern Gradle APIs and syntax (such as lazy properties and the java extension), and adjusting test code to align with behavior changes in updated dependencies like the Spring Boot plugin. The refactoring of the build logic is well-executed and necessary for the upgrade. The overall changes are correct and improve the build's robustness and maintainability. I have no specific comments as the implementation looks solid.
1 participant
Fixes #4474 🛠️