Skip to content

fix: use correct module to handle windows path separator #10108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foriequal0 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: use correct module to handle windows path separator #10108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/skaffold/helm/bin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
"io"
"os"
"os/exec"
"path"
"path/filepath"
"regexp"
"strings"
"time"
Expand Down Expand Up @@ -121,8 +121,8 @@ func PreparePostRenderer(ctx context.Context, h Client, skaffoldBinary string, h

// Take the temporary directory name as unique plugin name. That string is expected to
// be safe for direct %s insertion in the YAML Helm plugin manifest.
helmPluginName := path.Base(helmPluginDir)
err = os.WriteFile(path.Join(helmPluginDir, "plugin.yaml"), []byte(fmt.Sprintf(PostRendererTemplate, helmPluginName, skaffoldBinaryAsYaml)), 0644)
helmPluginName := filepath.Base(helmPluginDir)
err = os.WriteFile(filepath.Join(helmPluginDir, "plugin.yaml"), []byte(fmt.Sprintf(PostRendererTemplate, helmPluginName, skaffoldBinaryAsYaml)), 0644)
if err != nil &&
// Don't produce an error in tests that simulate the directory
!strings.HasPrefix(PluginInstallDir, "TEMPORARY-TEST-DIR") {
Expand Down