feat: Open in Folder with support for 3rd file manager#1045
Merged
Conversation
monkeyWie
requested changes
Jun 4, 2025
Member
monkeyWie
left a comment
There was a problem hiding this comment.
Thanks, this library seems to support all desktop os, and you can replace all implementations with it
Contributor
Author
|
ok, I will modify and test it tonight. |
Contributor
Author
|
I have made modifications and tested them on Mac and Linux |
monkeyWie
requested changes
Jun 5, 2025
| @@ -16,24 +17,11 @@ class FileExplorer { | |||
| } | |||
Member
There was a problem hiding this comment.
open_dir can also be used _openDirectory function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
- Coverage 67.17% 67.11% -0.07%
==========================================
Files 37 37
Lines 4753 4753
==========================================
- Hits 3193 3190 -3
- Misses 1255 1257 +2
- Partials 305 306 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
ok, I will modify it later |
Contributor
Author
|
I also modified the _openDirectory function |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When File Open in Folder, support 3rd file manager as system default, such as Directory Opus, etc
The code refers to localsend