Skip to content

feat: Open in Folder with support for 3rd file manager#1045

Merged
monkeyWie merged 3 commits into
GopeedLab:mainfrom
821869798:main
Jun 7, 2025
Merged

feat: Open in Folder with support for 3rd file manager#1045
monkeyWie merged 3 commits into
GopeedLab:mainfrom
821869798:main

Conversation

@821869798
Copy link
Copy Markdown
Contributor

When File Open in Folder, support 3rd file manager as system default, such as Directory Opus, etc
The code refers to localsend

@821869798 821869798 requested a review from monkeyWie as a code owner June 3, 2025 15:01
Copy link
Copy Markdown
Member

@monkeyWie monkeyWie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this library seems to support all desktop os, and you can replace all implementations with it

@821869798
Copy link
Copy Markdown
Contributor Author

ok, I will modify and test it tonight.

@821869798
Copy link
Copy Markdown
Contributor Author

I have made modifications and tested them on Mac and Linux

@@ -16,24 +17,11 @@ class FileExplorer {
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open_dir can also be used _openDirectory function.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.11%. Comparing base (7c541e4) to head (f51712d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   67.17%   67.11%   -0.07%     
==========================================
  Files          37       37              
  Lines        4753     4753              
==========================================
- Hits         3193     3190       -3     
- Misses       1255     1257       +2     
- Partials      305      306       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@821869798
Copy link
Copy Markdown
Contributor Author

ok, I will modify it later

@821869798
Copy link
Copy Markdown
Contributor Author

I also modified the _openDirectory function

@monkeyWie monkeyWie added the enhancement New feature or request label Jun 7, 2025
@monkeyWie
Copy link
Copy Markdown
Member

LGTM

@monkeyWie monkeyWie merged commit 5d84445 into GopeedLab:main Jun 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants