fix: update isCreate logic for pending tasks#1314
Merged
Merged
Conversation
Member
|
This condition is still not cautious enough, it is recommended to add an isCreated flag to indicate whether the task has created a file, otherwise the paused task will create a new file if it re-enters the waiting state |
Member
|
LGTM, but just keep |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 71.05% 71.03% -0.03%
==========================================
Files 49 49
Lines 6519 6521 +2
==========================================
Hits 4632 4632
- Misses 1459 1461 +2
Partials 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0d74adb to
cae0abc
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
isCreateflag indoStartwas ignoring tasks inWaitstatus. This caused theAutoRenamelogic to be skipped when a task moved from the queue to the running state, leading to file overwrites.Solution
base.DownloadStatusWaitin theisCreatelogic.task.Progress.Downloaded == 0check to prevent accidental renames on resumed tasks.Impact
Fixes #1286.