fix: prevent zombie processes by waiting for child process termination #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When terminating subprocess, always call wait() to properly reap the child process and prevent zombie processes. Added timeout handling with fallback to SIGKILL if the process doesn't terminate gracefully. Affected files: - app/xray/core.py: XRayCore.stop() now waits for xray process - app/dashboard/__init__.py: run_dev() cleanup now waits for npm process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After stopping or restarting the application, zombie processes remain because
subprocess.Popenchild processes are terminated but never reaped withwait().Solution
Added
wait()calls afterterminate()in:app/xray/core.py:XRayCore.stop()methodapp/dashboard/__init__.py:run_dev()cleanup handlerThe fix includes:
wait(timeout=5)afterterminate()to give the process time to exit gracefullykill()followed bywait()to force terminationTesting