Merge pull request #5 from GrabarzUndPartner/feature/preview

fix(preview): update readme; prepare for preview
GrabarzUndPartner · Jan 28, 2020 · 68f1de2 · 68f1de2
2 parents 4ed420e + 3267fbe
commit 68f1de2
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 9 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -32,7 +32,7 @@ jobs:
         - if [ -z "$TRAVIS_PULL_REQUEST_SHA" ]; then export PT_COMMIT=$TRAVIS_COMMIT; else export PT_COMMIT=$TRAVIS_PULL_REQUEST_SHA; fi
         # - echo $PT_COMMIT
         # - echo $PT_BRANCH
-        - npm run build
+        - npm run build --base=/nuxt-custom-elements/
     - stage: deploy
       if: branch = master
       install:
@@ -50,4 +50,6 @@ jobs:
         local_dir: gh-pages/
         on:
           branch: master
+        edge: true
+
 
diff --git a/README.md b/README.md
@@ -261,8 +261,17 @@ The custom elements contained in the page template can now be called.
 
 ## Preview
 
-1. Start static server using `npm run start:build`
-2. Open [http://127.0.0.1:3000](http://127.0.0.1:3000) in Browser.
+1. Clone this repository
+2. Install dependencies using `yarn install` or `npm install`
+3. Build and start with express `npm run start:build`
+4. Open [http://127.0.0.1:3000](http://127.0.0.1:3000) in Browser.
+
+or look here
+
+- [ComponentAppBundle](https://grabarzundpartner.github.io/nuxt-custom-elements/component-app-bundle.html)
+- [ComponentAppAbstract](https://grabarzundpartner.github.io/nuxt-custom-elements/component-app-abstract.html)
+- [ComponentAppHash](https://grabarzundpartner.github.io/nuxt-custom-elements/component-app-hash.html)
+- [ComponentAppHistory](https://grabarzundpartner.github.io/nuxt-custom-elements/component-app-history.html)
 
 ## Development
 

diff --git a/example/nuxt.config.js b/example/nuxt.config.js
@@ -27,6 +27,7 @@ module.exports = {
       '@/../', {
         analyzer: true,
         polyfill: true,
+        publicPath: getBasePath(),
         staticPath: resolve(process.cwd(), 'example/custom-element/static'),
         entries: [
           {
@@ -37,7 +38,7 @@ module.exports = {
                 path: '@/components/apps/AppAbstract',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               }
@@ -51,7 +52,7 @@ module.exports = {
                 path: '@/components/apps/AppHash',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               }
@@ -65,7 +66,7 @@ module.exports = {
                 path: '@/components/apps/AppHistory',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               }
@@ -79,7 +80,7 @@ module.exports = {
                 path: '@/components/apps/AppAbstract',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               },
@@ -88,7 +89,7 @@ module.exports = {
                 path: '@/components/apps/AppHash',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               },
@@ -97,7 +98,7 @@ module.exports = {
                 path: '@/components/apps/AppHistory',
                 options: {
                   props: {
-                    basePath: '/'
+                    basePath: getBasePath()
                   }
                 }
               }
@@ -108,3 +109,7 @@ module.exports = {
     ]
   ]
 }
+
+function getBasePath () {
+  return process.env.npm_config_base || '/'
+}
diff --git a/lib/tmpl/index.html.tmpl b/lib/tmpl/index.html.tmpl
@@ -4,7 +4,9 @@
 <head>
   <meta charset="utf-8">
   <title><%= htmlWebpackPlugin.options.title %></title>
+  <% if (base) { %>
   <base href="<%= base %>" target="_blank">
+  <% } %>
 </head>
 
 <body>