feat: add mlx chunked prefill support#469
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--chunked-prefill-sizewith a default of 1024;0disables chunking.Why
Long-prefill requests on macOS MLX could exceed memory because the prefill path ran the full prompt at once. During chunked testing, downstream peers could also drop queued chunks with the same request id, causing two-node pipeline requests to hang. This PR chunks the MLX prefill work, reuses prefix cache state across chunks, and keeps distinct same-rid prefill chunks queued until their turn.
Validation
pre-commit run --all-filespytest->143 passed, 5 skippedmlx-community/Qwen3.5-0.8B-MLX-bf16: node0 hosted layers[0, 12), node1 hosted layers[12, 24),--chunked-prefill-size 128; a 1675-token prompt completed successfully with 8 generated tokens.