feat: add sglang chunked prefill support#470
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Req,PrefillAdder,ScheduleBatch, and unfinished chunk cache lifecycle.chunked_prefill_sizeexplicitly into the scheduler and stop reading chunk size indirectly from the cache manager.Why
Parallax constructs
ScheduleBatchdirectly instead of using the upstream SGLang scheduler, so GPU chunked prefill needed a thin adapter around SGLang's native chunk selection and lifecycle primitives. This keeps the SGLang changes small while avoiding divergent MLX/SGLang chunk semantics.Validation
uv run --no-sync pre-commit run --all-filesuv run --no-sync pytestmy-windowswith--chunked-prefill-size 128[0,14)and[14,28), validating long-prompt semantic output