feat: new ui layout #132
Merged
feat: new ui layout #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
April 27, 2025 21:44
…to dev/v2-chat-ui
luoling8192
reviewed
Apr 28, 2025
apps/frontend/src/App.vue
Outdated
Comment on lines
11
to
15
| <template #default="{ changeTitle, setActions, setHidden, setCollapsed }"> | ||
| <RouterView v-slot="{ Component }"> | ||
| <component :is="Component" :change-title="changeTitle" :set-actions="setActions" :set-hidden="setHidden" :set-collapsed="setCollapsed" /> | ||
| </RouterView> | ||
| </template> |
There was a problem hiding this comment.
这里用 template 就好了，不需要额外写 slot，会自动处理的
Suggested change
| <template #default="{ changeTitle, setActions, setHidden, setCollapsed }"> | |
| <RouterView v-slot="{ Component }"> | |
| <component :is="Component" :change-title="changeTitle" :set-actions="setActions" :set-hidden="setHidden" :set-collapsed="setCollapsed" /> | |
| </RouterView> | |
| </template> | |
| <RouterView /> |
|
Rest LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress