docs: update DataSources examples to dataResolver format#6787
Open
Gxrvish wants to merge 1 commit into
Open
Conversation
Component-level data-variable props moved into the dataResolver object in GrapesJS#6495, but the docs still showed the old flat shape, which now fails silently (no render, no updates on record change). Style and trait data variables keep the flat shape, so those examples are left untouched.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DataSources docs still show the pre-#6495 flat shape for component-level
data-variable(defaultValue/pathas top-level props). Since #6495 thoseprops live in the
dataResolverobject, and the old shape fails silently —nothing renders and record updates are ignored (see the linked issue, where a
user copied the docs' counter example verbatim).
dataResolvershape, matchingtest/specs/data_sources/model/ComponentDataVariable.ts.test/specs/data_sources/dynamic_values/styles.ts/traits.ts), so thoseexamples are unchanged.