Skip to content

added release state display to info app #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DirkBaumeister
Copy link

I tried to add a release state to the release notes tab in the info app.

It should look like this:

Bildschirmfoto 2024-10-22 um 21 53 19

It fetches the current release state by using the android.os.Build.BOARD constant for stable, beta and alpha by constructing the url https://releases.grapheneos.org/$board-$releasePhase

Feedback is very much welcomed as these are my first steps in kotlin 😄

@matchboxbananasynergy
Copy link
Contributor

So this checks for which model you have and fetched the values for your own device? What channel a release is in can differ per device.

@DirkBaumeister
Copy link
Author

Yes, that's right.
As long as android.os.Build.BOARD gives the correct device name (husky for Pixel 8 Pro) for example it checks for the specific releases for this model the app is running on.
In the case of the Pixel 8 Pro it fetches for example the following urls:

https://releases.grapheneos.org/husky-stable
https://releases.grapheneos.org/husky-beta
https://releases.grapheneos.org/husky-alpha

and parses the release number from each request and shows it in the according box.

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name 😄

@matchboxbananasynergy
Copy link
Contributor

Thanks. We'll get around to looking at this soon.

@muhomorr
Copy link
Member

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

@DirkBaumeister
Copy link
Author

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

Thank you 🙂 I have changed it to this variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants