Improve clarity of web installer progress #1332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestinger
force-pushed
the
main
branch
7 times, most recently
from
2118467 to
7e60dbd
Compare
thestinger
force-pushed
the
main
branch
7 times, most recently
from
d97c2bd to
029d722
Compare
thestinger
force-pushed
the
main
branch
7 times, most recently
from
78d5bc2 to
bf9dbac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the web installer for the first time yesterday and it is wonderfully easy and straightforward. The only moment of confusion was when it took me a while to realize that the progress had actually completed, so this PR adds a bit more visual flavor to the success text and also hides the progress bar on completion.
Alternatively maybe it should change the progress bar color to green on completion, let me know what you think.