add native_bridge_supported for Cuttlefish build#349
Merged
Conversation
This seems to be required for Cuttlefish to build even for x86_64. Both scudo and jemalloc_new have this line in Android.bp as well. Note that AOSP doesn't have an arm64 to x86_64 translator. frameworks/libs/binary_translation/ currently only has a riscv64_to_x86_64 translator, so Cuttlefish currently has ro.dalvik.vm.native.bridge=0 hardened_malloc appears to otherwise be used for x86_64 apps in Cuttlefish x86_64. Test: lunch aosp_cf_x86_64_only_phone-cur-userdebug with bionic build fix boots Test: hardened_malloc was able to detect double free when running a test app that does a double free via JNI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be required for Cuttlefish to build even for x86_64. Both scudo and jemalloc_new have this line in Android.bp as well.
Note that AOSP doesn't have an arm64 to x86_64 translator. frameworks/libs/binary_translation/ currently only has a riscv64_to_x86_64 translator, so Cuttlefish currently has
ro.dalvik.vm.native.bridge=0hardened_malloc appears to otherwise be used for x86_64 apps in Cuttlefish x86_64.
Test:
lunch aosp_cf_x86_64_only_phone-cur-userdebugwith bionic build fix bootsTest: hardened_malloc was able to detect double free when running a test app that does a double free via JNI