Skip to content

Settings to block cross profile clipboard sharing on import and/or export towards other profiles #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 379 commits into
base: 15-qpr2
Choose a base branch
from

Conversation

quh4gko8
Copy link
Member

No description provided.

muhomorr and others added 30 commits March 5, 2025 15:07
"App info" screen now has a "Disable" button, which can be used as an
alternative to uninstallation.
Directory can be removed by the time listFiles() is called, which makes it return null. Null can
also be returned due to an I/O error.
APK is not yet available at the time of pre-approval request, which is incompatible with the
"Allow Network permission" checkbox in the confirmation dialog.

See PackageInstaller.Session#requestUserPreapproval() for more info.
Consumer Pixel devices have "MP1.0" as their hardware revision usually.
Devices stolen from Google will have "EVT", "PVT" or "DVT" set in
"ro.revision" by the bootloader. Additionally, check the secure boot
state prop set by the bootloader, "ro.boot.secure_boot", to ensure it is
set to "1", as typically pre-production devices won't have a blown
secure boot efuse, completely destroying any concept of verified boot.
Check both props, if either check fails, notify the user.

Squashed with: 778380b

Co-authored-by: Dmitry Muhomor <[email protected]>
Only user app IDs were written to `mDeviceIdleWhitelistAppIds`, both initially and when
`PowerManager.ACTION_POWER_SAVE_WHITELIST_CHANGED` broadcast was received. All other places that
listen to that broadcast retrieve both user and system app IDs.

The only place where `mDeviceIdleWhitelistAppIds` array is checked is in `isWhitelistedLocked()`,
which is called only by `updateTaskStateLocked()` to check whether the app is on the device idle whitelist.

It's not clear why DeviceIdleJobsController ignores system apps.
File level comment doesn't mention the distinction between system and user apps:
"When device is dozing, set constraint for all jobs, except whitelisted apps, as not satisfied."
Comment for isWhitelistedLocked() does, however:
"Checks if the given job's scheduling app id exists in the device idle user whitelist."
However, that method is called for both system and user apps, and returns false for system apps
because only whitelist of user apps is checked. This leads to long delays for jobs that were
submitted by whitelisted system apps when device is in the Doze mode. No such delays happen with
whitelisted user apps.

Other places use a different naming for array of app IDs that includes only user apps,
eg `mDeviceIdleWhitelistUserAppIds`, not `mDeviceIdleWhitelistAppIds`.

I've looked through the Git history of DeviceIdleJobsController and JobSchedulerService, but didn't
find a reason for this behavior. Perhaps, system apps were exempted from device idle JobScheduler
restricitions in some other place previously, or this was a bug from the start.

Tested on an emulator with the Messaging app, which uses JobScheduler
during processing of incoming SMS:
1. Check that Messaging app is on system deviceidle whitelist:
```
$ dumpsys deviceidle whitelist | grep com.android.messaging
system-excidle,com.android.messaging,10090
system,com.android.messaging,10090
```
2. Simulate sending an SMS: it appears immediately
3. Simulate Doze mode: `$ dumpsys deviceidle force-idle`
4. Simulate sending an SMS again. Message doesn't appear, even if the Messaging app is open
5. Exit Doze mode: `$ dumpsys deviceidle unforce`. All pending messages appear immediately
6. Add Messaging app to the user whitelist:
```
$ dumpsys deviceidle whitelist +com.android.messaging
$ dumpsys deviceidle whitelist | grep com.android.messaging
system-excidle,com.android.messaging,10090
system,com.android.messaging,10090
user,com.android.messaging,10090
```
7. Simulate Doze mode again: `$ dumpsys deviceidle force-idle`
8. Simulate sending an SMS, note that it appears immediately this time

Also made a test system app to make sure that this issue isn't caused by low targetSdk of the
Messaging app (it targets SDK 24). Same issue with targetSdk 32 app.

In both cases, applying this patch fixes the issue.
Needed for PackageManagerHooks.shouldFilterApplication() method.
This is done to have the build break in case grantImplicitAccess() starts to get used in more
places, which might weaken AppsFilter-based app isolation via PackageHooks.
Package permission state is updated automatically for all packages after events that might impact
it, e.g. after package install or uninstall, after storage volume mount, after OS update etc.

On GrapheneOS, per-package permission policy can be changed via GosPackageState packageFlags.
This new method is needed for updating the cached permission state manually after packageFlags
change.
Notification is not shown if OTHER_SENSORS was explicitly denied by the user.
Apps sometimes misbehave when INTERNET permission is revoked and a job that they scheduled with
a connectivity constraint is executed.
@quh4gko8 quh4gko8 force-pushed the 25Q1-dev_03-14_01 branch from 4e7018b to 3de1530 Compare March 16, 2025 03:23
muhomorr and others added 18 commits March 18, 2025 11:16
Split notification shade is used on tablets in landscape mode and on foldables in unfolded state.
This bug led to alarm and DND lockscreen info being misplaced.
This change also moves media info below alarm and DND info to improve transition animation between
always-on-display and lockscreen.
Keyguard slice view is replaced by smartspace view in SystemUIGoogle. Smartspace view is not
included in AOSP.
…e is used

Adjust the original change to addition of keyguard slice view by the previous commit.
Previous approach was to modify the ContentResolver query result, which doesn't work when Gservices
database is read directly, as is done in GmsCore in some cases now that Gservices database is
hosted by GmsCore.

Instead, use GservicesProvider's built-in support for flag overrides which is implemented by the
GSERVICES_OVERRIDE broadcast receiver.
Use the standard com.google.android.gms.phenotype.FLAG_OVERRIDE broadcast, which covers almost all
phenotype flag storage/access types, unlike the previous approach.
APEX installation support slightly increases the attack surface.
@quh4gko8 quh4gko8 force-pushed the 25Q1-dev_03-14_01 branch 2 times, most recently from 68d5021 to 0c9ede6 Compare March 26, 2025 15:29
@quh4gko8 quh4gko8 changed the title Extend disallowing clipboard access restriction to imports too Settings to block cross profile clipboard sharing on import and/or export towards other profiles Mar 26, 2025
@quh4gko8 quh4gko8 force-pushed the 25Q1-dev_03-14_01 branch from 0c9ede6 to ba64e85 Compare March 27, 2025 09:37
@quh4gko8 quh4gko8 closed this Apr 3, 2025
@quh4gko8 quh4gko8 reopened this Apr 3, 2025
@thestinger thestinger force-pushed the 15-qpr2 branch 5 times, most recently from 5f3142f to 8edf282 Compare April 10, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.