-
-
Notifications
You must be signed in to change notification settings - Fork 75
implement PIN/passphrase generation UI #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 15-qpr2
Are you sure you want to change the base?
Conversation
1fc6572
to
425ecac
Compare
0cda973
to
d3c03c8
Compare
666c89e
to
932b760
Compare
Changes since rebase:
|
ec4a72d
to
cf957c9
Compare
Changes since rebase:
|
cf957c9
to
8425d1b
Compare
8425d1b
to
9583dfa
Compare
This uses the standalone wallpaper picker class from WallpaperPicker2 as seen in the Pixel stock ROM.
The NFC preference in Settings -> Connected devices -> Connection preferences doesn't listen to changes from the NFC tile. (This wasn't an issue in Android 10, because there used to be a SwitchPreference that listened there.)
many carrier where 5G network options is available (in settings) doesn't really support standalone 5G and in that case setting it to 'NR/5G only' soft fails. it is disabled for NSA carrier, calling options will be broken on NSA (non standalone 5G).
…animation" This reverts commit cdfab94fdab8287e47e6a24bb1700a85ee250484.
9583dfa
to
5cff010
Compare
8010895
to
7a0d905
Compare
Changes:
|
cd9c06b
to
58dfee9
Compare
Changes:
|
57120ba
to
ecc0fae
Compare
It's already present in Developer options, but they are not available in secondary users.
Both override_desktop_mode_features and enable_freeform_support toggle had the same name UI name: "Enable freeform windows".
b944939
to
bd4524e
Compare
Passphrases have been implemented using EFF's Long Wordlist of 6^5 words. In terms of entropy, an 8-word passphrase would have a search space of (6^5)^8 ~= 2^103. This wordlist can be easily changed; just make sure to update the various constants in the DicewareWordList class Test: Manual Test: atest -c SettingsUnitTests:com.android.settings.password.generate (after building with m and running emulator) Test: SetupWizard2
- Increase the minimum number of words for diceware passphrases from 4 to 6, and the maximum from 8 to 10. - Update intro text for passphrases and PINs to be more descriptive with their respective length ranges. - Change manual passphrase description to a warning, indicating that an overly complex password may be less secure than a long passphrase. - Remove references to Titan M and just use the general "secure element" wording - Add handling for validation errors from AOSP's password activity, showing them in a new section of the UI. This should be very rare and the only reason this would happen if validation code between our code base drifts - Add a new `AOSPPasswordValidationError` class for parceling password validation errors
Add early validation of the selected generated passwords against AOSP's validation logic. This is achieved by launching the AOSP's ChooseLockPassword in a custom, validation-only mode before proceeding to the confirmation steps in our generated password Activity.
bd4524e
to
9fa9be4
Compare
Closes GrapheneOS/os-issue-tracker#599
Passphrases have been implemented using EFF's Long Wordlist of$6^5$ words. In terms of entropy, an 8-word passphrase would have a search space of $(6^5)^8 \approx 2^{103}$ . This wordlist can be easily changed; just make sure to update the various constants in the DicewareWordList class.
Test: Manual (normal user, work profile, and private space)
Test:
atest -c SettingsUnitTests:com.android.settings.password.generate
(after building with m and running emulator)Test: SetupWizard2: