Skip to content

Conversation

@ayush80942
Copy link

Fixes a issue dropped in #code-todo-list https://discord.com/channels/731730685944922173/881073965047636018/1450985374292906097

Test Results -

Screen.Recording.2025-12-20.at.7.mp4

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 87c0ef6
https://79803a58.graphite.pages.dev

@timon-schelling
Copy link
Member

image The bumping logic seems off.

@ayush80942
Copy link
Author

Hi @timon-schelling,

Thanks for the review! I want to make sure I understand the issue correctly before making changes.

Regarding "The bumping logic seems off" - could you clarify what specific behavior you're seeing?

I'm wondering if you're referring to:

  1. The dialog not being properly centred under its button when it opens? - It seems ok though
  2. The dialog position when it would overflow the window edges?
  3. The hover transfer behavior (when moving the mouse from one dropdown button to another)?

A quick description or additional screenshot/screen-recording would help me fix this correctly on the first try.

Thanks!

@timon-schelling
Copy link
Member

The second one, the bumping logic still needs to apply but also take into account the scroll position.

@ayush80942
Copy link
Author

Fixed the issue @timon-schelling
Screenshot 2025-12-21 at 3 10 44 PM

Now, the dialog stays visible completely till the button stays on the screen while scrolling.

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 2fa4740
https://38b176e4.graphite.pages.dev

@timon-schelling
Copy link
Member

image Good work, dialog should be closed when the button is not on screen, and the marker should not move past the dialog (minus corner radius).

@ayush80942
Copy link
Author

Fixed.

Screenshot 2025-12-21 at 6 05 38 PM

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for dd411a5
https://a69a31f8.graphite.pages.dev

@timon-schelling
Copy link
Member

image That solution leads to incorrect positions for dialogs originating from the side panel. see master behavior for comparison. image

@ayush80942
Copy link
Author

Apologies! Work fine now.

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 1362c0b
https://b57bf18f.graphite.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants