Added Traveler's birthday gift system#2549
Open
sitxovski wants to merge 1 commit intoGrasscutters:developmentfrom
Open
Added Traveler's birthday gift system#2549sitxovski wants to merge 1 commit intoGrasscutters:developmentfrom
sitxovski wants to merge 1 commit intoGrasscutters:developmentfrom
Conversation
Jimmy32767255
approved these changes
May 8, 2025
KingRainbow44
requested changes
May 26, 2025
Comment on lines
+18
to
+19
| private static final String MAIL_TITLE = "Best Wishes on Your Birthday"; | ||
| private static final String MAIL_CONTENT = "Happy Birthday, Traveler! Please find your gift attached to this message. Thank you for all your support. We wish you a brighter future, no matter what you are going through."; |
Member
There was a problem hiding this comment.
This part should be localized using the language system; not all players speak English
| // Mail content constants | ||
| private static final String MAIL_TITLE = "Best Wishes on Your Birthday"; | ||
| private static final String MAIL_CONTENT = "Happy Birthday, Traveler! Please find your gift attached to this message. Thank you for all your support. We wish you a brighter future, no matter what you are going through."; | ||
| private static final String MAIL_SENDER = "Server"; |
Member
There was a problem hiding this comment.
Consider using the configured server bot nickname instead of hardcoding the value
| int dateValue = Integer.parseInt(dateString); | ||
|
|
||
| // Store the date in player properties | ||
| player.getProperties().put(PlayerProperties.LAST_BIRTHDAY_GIFT_DATE, dateValue); |
Member
There was a problem hiding this comment.
This is not the thing to store in player properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a birthday gift system to Grasscutter:
The system is integrated with the existing mail system and is triggered on player login.