ci: accept the empty annotation form release-please leaves behind - #183
Merged
Conversation
bemcculley-graylog
approved these changes
Aug 27, 2026
aaronmgn
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When release-please bumps
version:, it round-tripsChart.yamland rewritesartifacthub.io/changes: |as"". The annotation generator matched only the block scalar form, so every release would fail to publish, after the tag and release already existed. It now accepts both forms and writes the block scalar back.What I changed: the first sentence was carrying two ideas joined by "and", so the round-trip is now its own statement. which fails the publish job became a plain clause with the actor named, and the bolted-on on every release moved into that sentence instead of trailing after a comma. I also cut before splicing, which named an internal step no reviewer needs, and fixed a factual slip in my own draft: the failure happens before packaging, not at it.