Frontend for the pluggable entity metrics endpoint (Inputs page) by ousmaneo · Pull Request #26094 · Graylog2/graylog2-server

ousmaneo · 2026-05-21T13:34:48Z

Wires the new GET /system/inputs/metrics endpoint into the Inputs overview as three opt-in, hidden-by-default columns. No metrics request fires unless the user enables one of them via the column picker.

New columns

Column	Source	Expanded section
Message Count (Last 24H)	`messages_per_stream` (sum of values)	per-stream breakdown — stream titles resolved via `POST /system/catalog/entities/titles`, deleted streams shown as `<id> (deleted)`
Extractors	`extractor_count`	lazy-loaded list from `GET /system/inputs/{inputId}/extractors`; "Manage extractors" lives in the section's actions slot
Associated Streams (Last 24H)	derived from `messages_per_stream` keys	linked list of stream titles

Each cell renders as a CountBadge with a chevron that flips when the matching section is open. While metrics are loading the cell shows a spinner; on error or missing data it falls back to — — the table itself never blocks on the metrics fetch (two-phase render).

Scope

Inputs page only. Streams, Forwarder Inputs, and Event Definitions columns from the broader project PRD are out of scope for this PR and will land with their own backend endpoints.
/nocl
associated to #25997
part of #25928

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have requested a documentation update.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.

laura-b-g

Tested and looking good in general. I have some comments in the code (nitpicks though). And I found one minor issue: For some reasons the columns in the message count table are not aligned in all cases, see screenshot:

laura-b-g · 2026-06-01T14:00:15Z

+): Promise<InputMetricsResponse> => {
+  const query = Qs.stringify({ input_ids: inputIds, fields }, { indices: false });
+
+  return fetch('GET', qualifyUrl(`/system/inputs/metrics?${query}`));


Is there an API stub that we can use instead?

We don't have the API stub yet because the backend is not ready for it.

laura-b-g · 2026-06-01T14:02:05Z

+  isInitialLoading: boolean;
+  isError: boolean;
+} => {
+  const stableEntities = useMemo(() => [...entities].sort((a, b) => a.id.localeCompare(b.id)), [entities]);


With react compiler I think we might not need this.

laura-b-g · 2026-06-01T14:02:10Z

+    placeholderData: keepPreviousData,
+  });
+
+  const titlesById = useMemo(() => {


With react compiler I think we might not need this.

laura-b-g · 2026-06-01T14:02:13Z

+    return result;
+  }, [data]);
+
+  const notPermittedIds = useMemo(() => new Set(data?.not_permitted_to_view ?? []), [data]);


With react compiler I think we might not need this.

laura-b-g · 2026-06-01T14:02:31Z

+  const stableIds = useMemo(() => sortedUnique(inputIds), [inputIds]);
+  const stableFields = useMemo(() => sortedUnique(fields), [fields]);


With react compiler I think we might not need useMemo

laura-b-g · 2026-06-01T14:12:42Z

  };

+  const [visibleInputIds, setVisibleInputIds] = useState<Array<string>>([]);
+  const onDataLoaded = useCallback((data: PaginatedResponse<Input>) => {


With React Compiler we might not need useCallback

laura-b-g · 2026-06-01T14:13:32Z

+  }, []);
+
+  const { data: layoutPreferences } = useUserLayoutPreferences(resolvedTableLayout.entityTableId);
+  const requestedFields = useMemo(() => {


With React Compiler we might not need useMemo

laura-b-g · 2026-06-01T14:17:44Z

+  const streamIds = useMemo(() => (messagesPerStream ? Object.keys(messagesPerStream) : []), [messagesPerStream]);
+  const titleEntities = useMemo(() => streamIds.map((id) => ({ id, type: 'streams' })), [streamIds]);


Same here: useMemo should not be needed?

laura-b-g · 2026-06-01T14:18:51Z

+
+import ExtractorsSection from './ExtractorsSection';
+
+jest.mock('logic/rest/FetchProvider', () => {


If we are using api stubs to fetch this data, we could simply mock the function for that stub. I think mocking the whole fetch provider is not ideal.

laura-b-g · 2026-06-01T14:20:32Z

+  const streamIds = useMemo(() => (messagesPerStream ? Object.keys(messagesPerStream) : []), [messagesPerStream]);
+  const titleEntities = useMemo(() => streamIds.map((id) => ({ id, type: 'streams' })), [streamIds]);


Again, do we need useMemo?

) * Add useEntityTitles hook for bulk id -> title resolution * Add useInputMetrics hook and per-page metrics context for Inputs * Add Message Count, Extractors, Associated Streams columns to Inputs * adjust extractors permissions * fix review --------- Co-authored-by: Laura Bergenthal-Grotlüschen <197286649+laura-b-g@users.noreply.github.com>

ousmaneo requested a review from a team May 22, 2026 07:12

ousmaneo added the ready-for-review label May 22, 2026

Base automatically changed from input_columns to master May 27, 2026 11:08

ousmaneo added 4 commits May 28, 2026 08:38

Add useEntityTitles hook for bulk id -> title resolution

d6830cd

Add useInputMetrics hook and per-page metrics context for Inputs

a85c702

Add Message Count, Extractors, Associated Streams columns to Inputs

b3e179f

adjust extractors permissions

e75ca80

ousmaneo force-pushed the feat/input-performances-fields-ui branch from 9915b9f to e75ca80 Compare May 28, 2026 06:42

ousmaneo added 2 commits May 28, 2026 15:27

Merge branch 'master' into feat/input-performances-fields-ui

996e107

Merge branch 'master' into feat/input-performances-fields-ui

de7d4b6

ousmaneo mentioned this pull request May 29, 2026

UI for Add metrics, input, and pipeline columns to Streams Overview #26127

Merged

9 tasks

ousmaneo and others added 2 commits May 29, 2026 13:56

Merge branch 'master' into feat/input-performances-fields-ui

e087ad9

Merge branch 'master' into feat/input-performances-fields-ui

34af26e

laura-b-g requested changes Jun 1, 2026

View reviewed changes

ousmaneo added 2 commits June 2, 2026 10:54

Merge branch 'master' into feat/input-performances-fields-ui

f350e79

fix review

14ffadc

ousmaneo requested a review from laura-b-g June 2, 2026 12:31

Merge branch 'master' into feat/input-performances-fields-ui

9ab95c3

laura-b-g approved these changes Jun 2, 2026

View reviewed changes

Merge branch 'master' into feat/input-performances-fields-ui

640d3cd

ousmaneo merged commit 50b01d6 into master Jun 3, 2026
24 checks passed

ousmaneo deleted the feat/input-performances-fields-ui branch June 3, 2026 07:58

Navigation Menu

Uh oh!

Frontend for the pluggable entity metrics endpoint (Inputs page) - #26094

Frontend for the pluggable entity metrics endpoint (Inputs page)#26094
ousmaneo merged 12 commits into
masterfrom
feat/input-performances-fields-ui

ousmaneo commented May 21, 2026 •

edited

Loading

Uh oh!

laura-b-g left a comment

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

ousmaneo Jun 2, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

laura-b-g Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const stableIds = useMemo(() => sortedUnique(inputIds), [inputIds]);
		const stableFields = useMemo(() => sortedUnique(fields), [fields]);

		const streamIds = useMemo(() => (messagesPerStream ? Object.keys(messagesPerStream) : []), [messagesPerStream]);
		const titleEntities = useMemo(() => streamIds.map((id) => ({ id, type: 'streams' })), [streamIds]);


		import ExtractorsSection from './ExtractorsSection';

		jest.mock('logic/rest/FetchProvider', () => {

Uh oh!

Conversation

ousmaneo commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New columns

Scope

Types of changes

Checklist:

Uh oh!

laura-b-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ousmaneo commented May 21, 2026 •

edited

Loading