Skip to content

Expose the search-cluster node name on NodeInfo - #26705

Merged
patrickmann merged 1 commit into
masterfrom
expose-node-name-on-nodeinfo
Aug 6, 2026
Merged

Expose the search-cluster node name on NodeInfo#26705
patrickmann merged 1 commit into
masterfrom
expose-node-name-on-nodeinfo

Conversation

@patrickmann

@patrickmann patrickmann commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

/nocl
/prd Graylog2/graylog-plugin-enterprise#14917

Description

The node stats adapter already fetches each search-cluster node's name from the _nodes response but dropped it: NodeInfo carried only version, OS, roles, and heap, keyed by node id.

The System Overview health panel's shard_count check (Graylog2/graylog-plugin-enterprise#14658) needs to join per-node shard counts (keyed by node name, from _cat/allocation) with per-node heap (keyed by node id, from _nodes). The only existing id-to-name bridge, ClusterAdapter.nodeIdToName(), is a per-node round-trip. This change exposes the node name on NodeInfo so a single _nodes read carries it, populated in the OpenSearch 2/3 and Elasticsearch 7 adapters.

Additive field on a serialize-only DTO, no behavior change on its own. Independent of other health-panel work and can merge standalone.

How Tested

  • Exercised end to end by the enterprise ShardCountHealthReporter unit tests in Graylog2/graylog-plugin-enterprise#14658, which join shard allocation to heap on this field.

@patrickmann
patrickmann force-pushed the expose-node-name-on-nodeinfo branch from bfb8809 to 27b6ad0 Compare July 20, 2026 15:49
@patrickmann
patrickmann changed the base branch from master to search-cluster-health-reporters July 20, 2026 15:49
@patrickmann
patrickmann marked this pull request as ready for review July 29, 2026 08:06
@patrickmann
patrickmann requested a review from a team July 29, 2026 08:06
Base automatically changed from search-cluster-health-reporters to master August 5, 2026 15:28
The node stats adapter already fetches each node's name from the _nodes
response but dropped it: NodeInfo carried only version, OS, roles, and heap,
keyed by node id. The System Overview health panel's shard-count check needs
to join per-node shard counts (keyed by node name, from _cat/allocation) with
per-node heap (keyed by node id, from _nodes), and the only existing id-to-name
bridge is a per-node round-trip. Populate the node name in the OpenSearch 2/3
and Elasticsearch 7 adapters so a single _nodes read carries it.

Enables Graylog2/graylog-plugin-enterprise#14658.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@patrickmann
patrickmann force-pushed the expose-node-name-on-nodeinfo branch from cfc6886 to b604e31 Compare August 5, 2026 18:48

@todvora todvora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@patrickmann
patrickmann merged commit a858698 into master Aug 6, 2026
27 checks passed
@patrickmann
patrickmann deleted the expose-node-name-on-nodeinfo branch August 6, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants