Adds bsSize props to Section component and extends options for titleAs - #26899
Open
maxiadlovskii wants to merge 2 commits into
Open
Adds bsSize props to Section component and extends options for titleAs#26899maxiadlovskii wants to merge 2 commits into
maxiadlovskii wants to merge 2 commits into
Conversation
linuspahl
reviewed
Aug 6, 2026
| disableCollapseButton?: boolean; | ||
| collapseButtonPosition?: 'left' | 'right'; | ||
| className?: string; | ||
| bsSize?: BsSize; |
Contributor
There was a problem hiding this comment.
Do we really want to support all four variants of "BsSize", or just the two which are currently needed?
Contributor
There was a problem hiding this comment.
When we only support two variants we would potentially have less inconsistency in the application longterm.
Contributor
Author
There was a problem hiding this comment.
@linuspahl for now, just 2. But it would be better to use the already existing prop regarding the size, just do not introduce a new one. And as bsSize everywhere else contains four variants it would be better to keep them. I think that will be more consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
adds a prop like bsSize and changes padding depending on the prop. It uses the same mapping as we have in buttons.
It also can extens titleAs to receive h4, h5
Motivation and Context
In the current implementation, we use the paddings theme.spacings.md, and in some cases it makes the container too big.
Check this PR
https://github.com/Graylog2/graylog-plugin-enterprise/pull/15118
We can't restyle it in my place of use because we have this padding for Container and Header depending on whether Section is expanded.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl