Auditor can be given additional context information - #26913
Open
luk-kaminski wants to merge 1 commit into
Open
Conversation
luk-kaminski
marked this pull request as ready for review
August 6, 2026 12:12
monrax
reviewed
Aug 6, 2026
| return audited(username, eventType, actionInput, auditableAction, SUCCESS_ON_NON_NULL, null); | ||
| } | ||
|
|
||
| public <T> T audited(final String username, |
Contributor
There was a problem hiding this comment.
this guy has no call sites. Should we drop it?
monrax
reviewed
Aug 6, 2026
| null, | ||
| Map.of(ERROR, String.valueOf(e.getMessage()))); | ||
| final Map<String, Object> extraWithError = new LinkedHashMap<>(); | ||
| if (extra != null) { |
Contributor
There was a problem hiding this comment.
what about passing Map.of() in the overloads? then
final Map<String, Object> extraWithError = new LinkedHashMap<>(extra);
extraWithError.put(ERROR, String.valueOf(e.getMessage()));
monrax
approved these changes
Aug 6, 2026
monrax
left a comment
monrax
left a comment
Contributor
There was a problem hiding this comment.
except for the incredibly minor nitpicks, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Auditor can be given additional context information.
/nocl
Motivation and Context
Sometimes, when audit logs are not created from the REST layer, some important pieces of information can be missing.
You can append them manually do the context.
How Has This Been Tested?
Manually.
Types of changes
Checklist: