Register the snapshot_archiving feature flag - #26917
Open
fpetersen-gl wants to merge 1 commit into
Open
Conversation
Default off. Consumed by graylog-plugin-enterprise, which gates the Snapshot Archiving config endpoint and UI on it. An unregistered flag already reads as off, so this can merge on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds one line to
feature-flag.config:snapshot_archiving=off.Motivation and Context
Feature flags are registered only in graylog2-server, so the entry for the enterprise Snapshot Archiving work belongs here. The plugin reads the flag to hide the Snapshot Archiving settings and to refuse them at the API.
Graylog treats an unknown flag as off, so this can merge before or after the plugin side without changing behaviour either way.
Part of Graylog2/graylog-plugin-enterprise#14686.
/nocl - Part of something bigger.
How Has This Been Tested?
ImmutableFeatureFlagsTestpasses (12 tests). The line itself carries no logic, so it has no test of its own.Types of changes
Checklist: