-
Notifications
You must be signed in to change notification settings - Fork 2
Improvement #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improvement #23
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
39c6e8b
it turnsout we have python-version but pyproject.toml
GreatBahram 304c43a
remove useless directories
GreatBahram 82c623d
Remove commented documentation and update logging warning format in S…
GreatBahram e49c341
add the bumpversion to the .bumpversion.cfg
GreatBahram fe54712
Bump version: 0.4.2 → 0.4.2
GreatBahram e44ddaf
Bump version: 0.4.2 → 0.4.3
GreatBahram 13cf118
fuck bumpversion
GreatBahram 5b61e4c
remove the bumpversion file
GreatBahram 7aae040
make ruff happy
GreatBahram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,4 @@ jobs: | |
| with: | ||
| name: dist | ||
| path: dist/ | ||
| retention-days: 5 | ||
| retention-days: 5 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ def update_resolv_file(content: list[str]) -> None: | |
| try: | ||
| shutil.copy(resolv_file, tmp_resolv_file) | ||
| except FileNotFoundError: | ||
| logger.warn(f"Resolv file not found ({resolv_file!s}).") | ||
| logger.warning(f"Resolv file not found ({resolv_file!s}).") | ||
| except OSError as e: | ||
| logger.error( | ||
| f"Could not move resolv file ({resolv_file!s}) to " | ||
|
|
@@ -140,7 +140,7 @@ def shecan_cli() -> Optional[int]: | |
|
|
||
| args = parser.parse_args() | ||
|
|
||
| if len(sys.argv) == 1: | ||
| if len(sys.argv) == 1 or not hasattr(args, "op"): | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was a bug 🤷 |
||
| parser.print_help(sys.stderr) | ||
| return 1 | ||
|
|
||
|
|
||
File renamed without changes.
File renamed without changes.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warn has been deprecated!