feat(ElectricityMaps source): unify ElectricityMaps and ElectricityMapsFree #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eply.github.com> I, Robin TROESCH <[email protected]>, hereby add my Signed-off-by to this commit: b086396 I, Robin TROESCH <[email protected]>, hereby add my Signed-off-by to this commit: e3ba7d1 Signed-off-by: Robin TROESCH <[email protected]>
12 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the ElectricityMaps and ElectricityMapsFree sources by removing all references and dependencies on ElectricityMapsFree in both documentation and test code. Key changes include updating documentation to reflect only the ElectricityMaps source, removing the ElectricityMapsFree controllers and tests, and revising configuration examples and environment variable settings.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| casdk-docs/docs/tutorial-extras/selecting-a-data-source.md | Removed references to ElectricityMapsFree from the data source table. |
| src/CarbonAware.CLI/test/integrationTests/IntegrationTestingBase.cs | Removed the ElectricityMapsFree using/import and case block and updated environment variable settings. |
| casdk-docs/docs/overview/enablement.md | Eliminated the ElectricityMapsFree link from the enablement list. |
| src/CarbonAware.CLI/test/integrationTests/Commands/Emissions/EmissionsCommandTests.cs | Removed the ElectricityMapsFree test fixture. |
| samples/casdk-demo/README.md | Updated sample configuration from ElectricityMapsFree to ElectricityMaps. |
| casdk-docs/docs/quickstart.md | Adjusted configuration examples to remove ElectricityMapsFree references. |
| casdk-docs/docs/architecture/data-sources.md | Removed ElectricityMapsFree from the data sources list. |
| casdk-docs/docs/tutorial-extras/packaging.md | Cleared out ElectricityMapsFree related configuration and project references. |
| casdk-docs/docs/tutorial-extras/carbon-aware-library.md | Deleted ElectricityMapsFree sections from the library documentation. |
| casdk-docs/docs/architecture/c-sharp-client-library.md | Removed ElectricityMapsFree from the client library documentation. |
| src/CarbonAware.CLI/test/integrationTests/Commands/Location/LocationCommandTests.cs | Removed the ElectricityMapsFree test fixture. |
| casdk-docs/docs/tutorial-extras/containerization.md | Eliminated ElectricityMapsFree Docker run instructions. |
| casdk-docs/docs/tutorial-basics/containerization.md | Similar removal of ElectricityMapsFree instructions. |
| casdk-docs/docs/tutorial-basics/carbon-aware-webapi.md | Removed ElectricityMapsFree sections from the WebAPI documentation. |
| casdk-docs/docs/tutorial-extras/configuration.md | Removed config sections related to ElectricityMapsFree. |
| src/CarbonAware.CLI/test/integrationTests/Commands/EmissionsForecasts/EmissionsForecastsCommandTests.cs | Removed commentary/test fixture for ElectricityMapsFree. |
| src/CarbonAware.DataSources/CarbonAware.DataSources.ElectricityMapsFree/mock/ElectricityMapsFreeDataSourceMocker.cs | Removed the ElectricityMapsFree data source mocker entirely. |
13 tasks
|
Thank you very much for this contribution. It (this PR) does not seem to compile correctly though, to pass the basic checks. @unitrium are you able to double check you committed everything you had planned to please? Let me know if you need any help. cc @jbdietrich |
|
Thanks, I will double-check and see what I can do |
…eply.github.com> I, Robin TROESCH <[email protected]>, hereby add my Signed-off-by to this commit: ea41012 Signed-off-by: Robin TROESCH <[email protected]>
|
Seems to be working now. Ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number: #613
Summary
Remove all references to ElectricityMapsFree as it has been unified with ElectricityMaps.
Changes
Checklist
Are there API Changes?
No API changes expected.
Is this a breaking change?
The ElectricityMapsFree source will no longer be available.
Anything else?
cc @jbdietrich
This PR Closes #613