feat(rest-client): timestamp insertion when used with observe #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compute Signed-off-by: KAMEDA Kaito <[email protected]>
YaSuenag
reviewed
Jun 5, 2025
docs/rest-client.md
Outdated
| ### Plugin config | ||
|
|
||
| The parameters are required in config: `method`, `url`, `data`, `headers`, `http-basic-authentication`, `tls-verify`, `jpath` and `output`. | ||
| The parameters are required in config: `method`, `url`, `data`, `headers`, `http-basic-authentication`, `tls-verify`, `jpath`, `observtion-timestamp` and `output`. |
Member
There was a problem hiding this comment.
Typo? observtion -> observation
Contributor
Author
There was a problem hiding this comment.
Thank you. I missed that.
YaSuenag
reviewed
Jun 5, 2025
docs/rest-client.md
Outdated
| ``` | ||
| - `tls-verify`: optional, the server certificate is verified against the list of supplied CAs if true or undefined. `true` is set by default. | ||
| - `jpath`: JSONPath expression and you can use it when using the GET method | ||
| - `observation-timestamp`: optional, the execution timestamp will be automatically inserted into the `inputs` when using this plugin with `observe` if `true`. `false` is set by default. This option should not be set to `true` when used with `compute`. An error will occur if this option is set to `true` while a `timestamp` already exists in the `inputs`. |
Member
There was a problem hiding this comment.
I guess it is better to other name - e.g. insert-timestamp, observe-mode, observe.
Contributor
Author
There was a problem hiding this comment.
That's a nice name. I chose observe-mode
Signed-off-by: KAMEDA Kaito <[email protected]>
Contributor
Author
|
Thank you for your advice. I fixed them. Could you please check them? |
YaSuenag
approved these changes
Jun 6, 2025
Member
YaSuenag
left a comment
YaSuenag
left a comment
There was a problem hiding this comment.
LGTM
Thanks a lot for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… compute
Types of changes
A description of the changes proposed in the Pull Request
inputswhen this plugin is used withobserve. If the plugin is used withobserveand atimestampalready exists in theinputs, an error will be returned