ci: publish to PyPi on new release, fixes #141 #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidg
requested review from
andreww,
colinsauze,
tonymugen and
sadielbartholomew
sadielbartholomew
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
By eyeball, looks to configure the dedicated publish external workflow correctly for our context and the YAML is all valid so nothing strikes me as amiss, however I don't know a good way to test it explicitly without changing it around too much to use TestPyPI - don't want to accidentally create a new official release from a test/fork branch!
Happy to approve regardless but for validation/reassurance it would be good to know it has been tested - have you checked this via publishing to TestPyPI or otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.